WeLoveCSS Logo
Home Profile Members Search Rules Help New Posts

WeLoveCSS > SOCIAL CHAT > Website Gallery > Please critique layout

Reply
  Thread Tools Display Modes
Old 3rd February 10, 06:06 AM   #11
djpete
WLC Lover
 
Join Date: Nov 2009
Posts: 68
Default Re: Please critique layout

I can't find the css style embedded in your doc for the rcol div...
class="textpadding .
<code>
<div id="rcol">
<p class="textpadding">Lorem ipsum dolor sit amet consectetuer nisl vitae porttitor id ut. Habitasse
In aliquam magna consectetuer Quisque lorem Nam et sapien et. Ut vitae ac venenatis malesuada id ipsum
nibh mattis Vestibulum orci.</p>
</div>
</code>

But it IS padding that div so it must be somewhere.
I think im going mad...
djpete is offline   Reply With Quote
Old 3rd February 10, 06:56 AM   #12
djpete
WLC Lover
 
Join Date: Nov 2009
Posts: 68
Default Re: Please critique layout

ok I took <p class="textpadding"> out and it made no difference so I presume that was left in by mistake?

But padding seems to be on all text but I cant see any left right padding on any styles. How did you do that?

I suspect it must be done here?

..............
h1,h2,h3,p{margin:0 .5em .5em; font-size:1.5em;}
h1{padding-top:.3em; margin-bottom:.15em}
h2{font-size:1.2em;}
h3{font-size:1.1em;}
p{font-size:1em;}
djpete is offline   Reply With Quote
Old 3rd February 10, 09:37 PM   #13
djpete
WLC Lover
 
Join Date: Nov 2009
Posts: 68
Default Re: Please critique layout

aha

h1,h2,h3,p{margin:0 .5em .5em; font-size:1.5em;}
h1{padding-top:.3em; margin-bottom:.15em}
h2{font-size:1.2em;}
h3{font-size:1.1em;}
p{font-size:1em;}

Its in the margins.
I see now. Of course its not padding the text. It's actually margining the text so that's why you used margin. All clear.

Now I just need this answered and I will understand all of your markup...

Can you explain a bit more why this was done?
overflow:hidden;/*contain inner floats*/
Even if I leave this out I still don't get any scrollbars etc so is this done to overcome an IE issue or something?

Thanks,
I'll be using this type of markup as my blueprint.
:-)

Last edited by djpete; 3rd February 10 at 09:48 PM.
djpete is offline   Reply With Quote
Old 3rd February 10, 10:07 PM   #14
djpete
WLC Lover
 
Join Date: Nov 2009
Posts: 68
Default Re: Please critique layout

Got it.
Pls correct me if wrong.

You added overflow hidden in case a large pic is added so that it would not destroy the layout.
To test this I added a pic that was too wide and then changed overflow hidden to visible. YUK! Overflow hidden does what it says. Anything bigger than the container will be just that...HIDDEN.

Now I am 100% clear on it all.
I can use this knowing why.
:-)
djpete is offline   Reply With Quote
Old 12th February 10, 04:46 AM   #15
Smacksmacksmack
WLC Member
 
Join Date: Feb 2010
Posts: 11
Default Re: Please critique layout

Needs some more flashy images
Smacksmacksmack is offline   Reply With Quote
Reply


Thread Tools
Display Modes
Linear Mode Linear Mode

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 04:55 PM.



Home | Advertise | Contact Us | Top
Home | Advertise | Contact Us | Top

Copyright© 2006 WeLoveCSS.com. All Rights Reserved. Designed by DESIGNGRAPHY
Powered by vBulletin Version 3.8.4 Copyright ©2000 - 2010, Jelsoft Enterprises Ltd.